Increase edge case check strictness when cols_droplevel contains empty values #62527
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Oct 1, 2025
Comment on lines
275
to
282
| # GH 62518 | ||
| df4 = DataFrame( | ||
| columns=MultiIndex.from_arrays( | ||
| [["a", "a", "z", "z"], pd.Categorical([1, 2, 1, 2])], | ||
| ), | ||
| dtype=object, | ||
| ) | ||
| df4["z"] = df4["z"].astype("int64") |
There was a problem hiding this comment.
Could you make this a separate test that uses the exact code snippet in the original issue?
mroeschke
reviewed
Oct 1, 2025
| ), | ||
| dtype=object, | ||
| ) | ||
| meta["z"] = meta["z"].astype("int64") |
There was a problem hiding this comment.
Sorry, one more thing. Could you use tm.assert_frame.equal to assert that meta is equal to a new DataFrame that's the result of this casting?
mroeschke
approved these changes
Oct 2, 2025
|
Thanks @matiaslindgren |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.__setitem__with DataFrame, Categorical level of MultiIndex in pandas 3.x #62518doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.